Get CI to check PRs have been signed-off

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.

https://matrix-org.github.io/synapse

Apache License 2.0

11.82k stars 2.13k forks source link

Closed DMRobertson closed 1 year ago

DMRobertson commented 1 year ago

Uses Half-Shot's action from https://github.com/matrix-org/backend-meta/blob/release/v2/.github/workflows/sign-off.yml. I've set this up in the sliding sync repo and it seems to have worked well.

DMRobertson commented 1 year ago

Just a review :)

DMRobertson commented 1 year ago

~~Oh, and a merge conflict to be resolved too, it seems.~~

clokep commented 1 year ago

Just a review :)

FTR this is in draft still. 😄

DMRobertson commented 1 year ago

:facepalm: thanks, that'd be why GH wasn't showing me a big "merge this now" button.