Synapse fetches this value from the config and casts it to a string, no matter what it was before. Using floats for protocol identifiers rubs me the wrong way, so I wanted to update the docs here. Synapse works with both a float and string here, so it's just a matter of adjusting the docs.
[x] Pull request includes a changelog file. The entry should:
Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
Use markdown where necessary, mostly for code blocks.
End with either a period (.) or an exclamation mark (!).
Start with a capital letter.
Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
clokep
commented
1 year ago
Synapse fetches this value from the config and casts it to a string, no matter what it was before. Using floats for protocol identifiers rubs me the wrong way, so I wanted to update the docs here. Synapse works with both a float and string here, so it's just a matter of adjusting the docs.
Signed-off-by: Jan Christian Grünhage jan.christian@gruenhage.xyz
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.