search

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://matrix-org.github.io/synapse
Apache License 2.0
11.83k stars 2.13k forks source link

Updating avatar also unsets unread notification counts for all rooms #16373

Open fnwbr opened 1 year ago

fnwbr commented 1 year ago

Description

Similarly to https://github.com/matrix-org/synapse/issues/16059 setting a new avatar via /_matrix/client/v3/profile/{userId}/avatar_url also marks all notifications as read, as in, marks all rooms that have "unread notifications" as done.

Steps to reproduce

None of the platform-specific details below are relevant; this issue is more to discuss if this behavior is really intended.

### Homeserver / ### Synapse Version v1.92.3 ### Installation Method Docker (matrixdotorg/synapse) ### Database PostgreSQL
clokep commented 1 year ago

Just to confirm -- is the notification count being cleared from the homeserver or is the client using a local receipt to mark everything as read?

neilisfragile commented 11 months ago

Talking to the Element Web team, it is the server resetting the count.

Related. Same mechanism for display name https://github.com/matrix-org/synapse/issues/9716

fnwbr commented 11 months ago

Can confirm that the same thing happens for changing your display name.

@clokep Sorry for the radio silence before; must have overlooked the email for your comment.