Fix possible AttributeError when account-api is called over unix socket - Githubissues

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.

https://matrix-org.github.io/synapse

Apache License 2.0

11.83k stars 2.13k forks source link

Fix possible AttributeError when account-api is called over unix socket #16404

Closed Sir-Photch closed 1 year ago

Sir-Photch commented 1 year ago

Fixes #16396

Pull Request Checklist

[x] Pull request is based on the develop branch
[x] Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
[x] Pull request includes a sign off via email
[x] Code style is correct (run the linters)

erikjohnston commented 1 year ago

@Sir-Photch you need to sign off this PR, as per the contributing guide.

Sir-Photch commented 1 year ago

@erikjohnston I've sent you guys an email about that

InezMc commented 1 year ago

Private sign off has been recieved.

@Sir-Photch you need to sign off this PR, as per the contributing guide.

erikjohnston commented 1 year ago

Thanks both!