search

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://matrix-org.github.io/synapse
Apache License 2.0
11.83k stars 2.13k forks source link

Convert simple_search_list/simple_search_list_txn to return tuples. #16434

Closed clokep closed 1 year ago

clokep commented 1 year ago

More removals of cursor_to_dict. This one might be controversial since it just manually creates the dict at the REST layer.

I assert that this is better because it is explicit about the information we return to clients, as opposed to choosing from the database layer.

It also does a couple of other simplifications while I was there.

See #16431.

clokep commented 1 year ago

Also filed #16443 about there being no docs for this endpoint.

clokep commented 1 year ago

Looks good, but complement is failing in a way I don't recognise. Is it a regression?

Seems to be failing on develop in the same way: https://github.com/matrix-org/synapse/actions/runs/6469190463/job/17562829355