Create pylint.yml - Githubissues

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.

https://matrix-org.github.io/synapse

Apache License 2.0

11.83k stars 2.13k forks source link

Create pylint.yml #16446

Closed Agentofchaoss closed 1 year ago

Agentofchaoss commented 1 year ago

Pull Request Checklist

[ ] Pull request is based on the develop branch
[ ] Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
[ ] Pull request includes a sign off
[ ] Code style is correct (run the linters)

DMRobertson commented 1 year ago

If you're going to submit a pull request, please explain what your change does and why you want to include it in Synapse.

Regarding pylint, we have found ruff and mypy to be more than sufficient for our linting. What additional checks would we gain with pylint?

Additionally, please do not file duplicate pull requests: https://github.com/matrix-org/synapse/pull/16447 and also https://github.com/matrix-org/synapse/pull/16482.

DMRobertson commented 1 year ago

The comments on https://github.com/matrix-org/synapse/pull/16482 apply here too.