Improve performance of delete device messages query - Githubissues

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.

https://matrix-org.github.io/synapse

Apache License 2.0

11.83k stars 2.13k forks source link

Improve performance of delete device messages query #16492

Closed MatMaul closed 1 year ago

MatMaul commented 1 year ago

cf #16479.

Signed-off-by: Mathieu Velten matmaul@gmail.com

Pull Request Checklist

[x] Pull request is based on the develop branch
[x] Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
[x] Pull request includes a sign off
[x] Code style is correct (run the linters)

MatMaul commented 1 year ago

~I am getting less rows deleted with this new query (10 instead of 12), I need to check why.~ All is fine. cf https://github.com/matrix-org/synapse/issues/16479#issuecomment-1763158117 for more infos and PG plans for old and new queries.

MatMaul commented 1 year ago

I think this is fine so undrafting it, but it may be useful to check a plan on pg11 with the new query.