Convert simple_select_list and simple_select_list_txn to return lists of tuples

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.

https://matrix-org.github.io/synapse

Apache License 2.0

11.83k stars 2.13k forks source link

Convert simple_select_list and simple_select_list_txn to return lists of tuples #16505

Closed clokep closed 1 year ago

clokep commented 1 year ago

More of #16431, this is again fairly large since these are used everywhere.

clokep commented 1 year ago

(I probably need to double check the return types of these.)

clokep commented 1 year ago

@DMRobertson Any thoughts on this? Should I just file issues for the above?

DMRobertson commented 1 year ago

@DMRobertson Any thoughts on this? Should I just file issues for the above?

My preference would be to update the type hints that doesn't cause new type errors. If there are new type errors, then yeah let's file an issue. (Also happy for you to punt it and just file an issue :))