matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://matrix-org.github.io/synapse
Apache License 2.0
11.83k stars 2.13k forks source link

complement: enable dirty runs #16520

Closed kegsay closed 1 year ago

kegsay commented 1 year ago

Pull Request Checklist

clokep commented 1 year ago

This had 1 flake, not sure if that's expected or not?

kegsay commented 1 year ago

Unsure. The increases concurrency means we see different kinds of flakes from before. They are always the partial state join tests though, and they've passed in the past, so tempted to merge and ignore, but this isn't my project :D

kegsay commented 1 year ago

The cause of the flakiness was terribly slow partial state tests, caused by the reduced connection pool limits on postgres mode. It's now only reducing the connection pool when running with workers.