search

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://matrix-org.github.io/synapse
Apache License 2.0
11.83k stars 2.13k forks source link

Pin the recommended poetry version in contributors' guide #16550

Closed DMRobertson closed 1 year ago

DMRobertson commented 1 year ago

A stopgap until we work out what to do with https://github.com/matrix-org/synapse/issues/16147

clokep commented 1 year ago

(I think we're just waiting for a new release of poetry-core + poetry btw.)

DMRobertson commented 1 year ago

(I think we're just waiting for a new release of poetry-core + poetry btw.)

interesting. there's a 1.7 release out already but presumably that lacks the fix we want?

clokep commented 1 year ago

(I think we're just waiting for a new release of poetry-core + poetry btw.)

interesting. there's a 1.7 release out already but presumably that lacks the fix we want?

See https://github.com/matrix-org/synapse/issues/16147#issuecomment-1741040730, we need https://github.com/python-poetry/poetry-core/pull/633 which was after the 1.7 release.

clokep commented 1 year ago

(Maybe it would work if we required poetry-core < 1.6, but I think @erikjohnston checked that and it didn't work.)