search

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://matrix-org.github.io/synapse
Apache License 2.0
11.83k stars 2.13k forks source link

Run actions/setup-go after checking out complement #16567

Closed DMRobertson closed 1 year ago

DMRobertson commented 1 year ago

This should suppress the warnings in test runs, e.g. from https://github.com/matrix-org/synapse/actions/runs/6673818366?pr=16565 image

and presumably make it mildly quicker to prepare the complement test binary.

DMRobertson commented 1 year ago

Let's see if this works by checking https://github.com/matrix-org/synapse/actions/runs/6678497686?pr=16567

clokep commented 1 year ago

Still has a warning about go version but unsure we care?

DMRobertson commented 1 year ago

Still has a warning about go version but unsure we care?

Namely:

image

I think I can fix that too, while I'm at it.

clokep commented 1 year ago

Complement seems to be failing now?

DMRobertson commented 1 year ago

My bet is that the go version declared in complement's go.mod is too low. Which seems like a surprising oversight, but should be easy enough to fix.

clokep commented 1 year ago

My bet is that the go version declared in complement's go.mod is too low. Which seems like a surprising oversight, but should be easy enough to fix.

Sounds like an oversight in the complement CI too then?

DMRobertson commented 1 year ago

My bet is that the go version declared in complement's go.mod is too low. Which seems like a surprising oversight, but should be easy enough to fix.

Sounds like an oversight in the complement CI too then?

More like in complement's dependency/project definitions, but otherwise yes. https://github.com/matrix-org/complement/pull/687 should fix.

DMRobertson commented 1 year ago

complement change landed. Rerunning.

DMRobertson commented 1 year ago

Complement seems happier now.