search

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://matrix-org.github.io/synapse
Apache License 2.0
11.82k stars 2.13k forks source link

Use dbname instead of database for Postgres config. #16618

Closed clokep closed 11 months ago

clokep commented 11 months ago

According to the psycopg2 docs the connection should use dbname:

dbname – the database name (database is a deprecated alias)

I don't think we need to do mapping or anything in the config since we document this as drive-specific configuration.

This was taken from my psycopg3 branch, which requires using dbname.

DMRobertson commented 11 months ago

I don't think we need to do mapping or anything in the config since we document this as drive-specific configuration.

Though we probably would(?) want to do this in the future if we drop support for psycopg2.

clokep commented 11 months ago

I don't think we need to do mapping or anything in the config since we document this as drive-specific configuration.

Though we probably would(?) want to do this in the future if we drop support for psycopg2.

I'm expecting people to opt into psycopg(3) so they would need the appropriate configuration for that anyway.