Add config to change the delay before sending a notification email

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.

https://matrix-org.github.io/synapse

Apache License 2.0

11.79k stars 2.13k forks source link

Add config to change the delay before sending a notification email #16696

Closed MatMaul closed 9 months ago

MatMaul commented 10 months ago

Signed-off-by: Mathieu Velten mathieu.velten@beta.gouv.fr

Pull Request Checklist

[x] Pull request is based on the develop branch
[x] Pull request includes a changelog file.
[x] Pull request includes a sign off
[x] Code style is correct (run the linters)

MatMaul commented 10 months ago

I am having a look at the throttle mechanism. I think it doesn't really make sense to have a MIN inferior to the delay, so I am thinking about setting THROTTLE_START_MS equals to the delay.

MatMaul commented 9 months ago

I've addressed the comments, and set THROTTLE_START_MS to be the specified delay instead of being a constant.

MatMaul commented 9 months ago

We would also need some configuration nobs to tweak throttle max and throttle multiplier, but I was thinking about doing that in another PR. I can add that to this one if you prefer.