matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://matrix-org.github.io/synapse
Apache License 2.0
11.83k stars 2.12k forks source link

Upgrade poetry-core range to fix #16147 #16702

Closed thebalaa closed 11 months ago

thebalaa commented 11 months ago

This fixes #16147 but I'm not sure this is precisely the right version bound. Looking through Poetry related issues directly or indirectly related to #16147 I tend to argue Poetry has created more problems than benefit and would prefer removing it altogether.

For example, we are using an unsupported Poetry mechanism for building the Rust synapse.synapse_rust modules, see https://github.com/python-poetry/poetry/issues/2740#issuecomment-665073135

Happy to make the necessary changes in order to improve the new contributor onboarding experience, whatever they may be.

Pull Request Checklist

Signed-off-by: Mo Balaa mo@fractalnetworks.co

DMRobertson commented 11 months ago

Can you add a changelog entry please, so we can get CI churning? I tried to add one to this PR myself, but I don't think I have write access to your fork's branch. Here's my suggestion:

From 161330f3383ee04d8f4d6249e939b3c883540c10 Mon Sep 17 00:00:00 2001
From: David Robertson <davidr@element.io>
Date: Wed, 29 Nov 2023 18:06:22 +0000
Subject: [PATCH] Changelog

---
 changelog.d/16702.misc | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 changelog.d/16702.misc

diff --git a/changelog.d/16702.misc b/changelog.d/16702.misc
new file mode 100644
index 0000000000..be5a508208
--- /dev/null
+++ b/changelog.d/16702.misc
@@ -0,0 +1 @@
+Raise poetry-core upper bound to <=1.8.1. This allows contributors to import Synapse after `poetry install`ing with Poetry 1.6 and above.
-- 
2.43.0