Write signing keys with file mode 0640 - Githubissues

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.

https://matrix-org.github.io/synapse

Apache License 2.0

11.83k stars 2.12k forks source link

Write signing keys with file mode 0640 #16740

Closed elara-leitstellentechnik closed 11 months ago

elara-leitstellentechnik commented 11 months ago

Fixes #1528. Fixes #6364.

Pull Request Checklist

[x] Pull request is based on the develop branch
[x] Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
[x] Pull request includes a sign off
[x] Code style is correct (run the linters)

elara-leitstellentechnik commented 11 months ago

Your suggestion doesn't work as the type of argparse.FileType is not a PathLike or similar, but just the opened file.

I therefore refactored the script a bit. This has the nice benefit, that the file is properly closed now as well (which I believe it wasn't before.