search

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://matrix-org.github.io/synapse
Apache License 2.0
11.79k stars 2.13k forks source link

Docker Image - Allow to define trusted_third_party_id_servers #5194

Closed nsteinmetz closed 5 years ago

nsteinmetz commented 5 years ago

Description:

You cannot define trusted_third_party_id_servers by using environment variables for the docker image - cf https://github.com/matrix-org/synapse/blob/master/docker/conf/homeserver.yaml#L161-L163

So if you want to run your own mxisd server for ex, you can't define it and must edit the yaml file somehow.

We could have something like:

trusted_third_party_id_servers:
{% if SYNAPSE_TRUSTED_ID_SERVERS %}
{% for server in SYNAPSE_TRUSTED_ID_SERVERS.split(',') %}    - {{ server }}
{% endfor %}
{% else %}
    - matrix.org
    - vector.im
{% endif %}

and as environment variable:

SYNAPSE_TRUSTED_ID_SERVERS = id1.example.com,id2.example.com
hawkowl commented 5 years ago

As per https://github.com/matrix-org/synapse/issues/5518 , we're going to recommend people configure this in a proper config file, as maintaining environment variables for every option is getting unwieldy, hard to maintain, and harder to write documentation for.