search

matrix-org / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://matrix-org.github.io/synapse
Apache License 2.0
11.79k stars 2.13k forks source link

event_push_actions don't seem to be cleaned for some of my rooms #6060

Open ara4n opened 4 years ago

ara4n commented 4 years ago

specifically, i have 19 entries in the EPA table for !zVpPeWAObqutioiNzB:jki.re despite being caught up on it. I thought every time i send a read receipt, my EPA entries from before the point I sent the read receipt should get cleaned out by _remove_old_push_actions_before_txn?

richvdh commented 2 years ago

still a thing, maybe?

matrix=> select epa.* from event_push_actions epa where epa.room_id='!zVpPeWAObqutioiNzB:jki.re' and user_id='@matthew:matrix.org';
          room_id           |                   event_id                   |       user_id       | profile_tag |                        actions                        | topological_ordering | stream_ordering | notif | highlight | unread 
----------------------------+----------------------------------------------+---------------------+-------------+-------------------------------------------------------+----------------------+-----------------+-------+-----------+--------
 !zVpPeWAObqutioiNzB:jki.re | $HxQKgRzFnSAyYlFn5LrHY0wm3NzFEFfuoipmrEJyrWo | @matthew:matrix.org |             |                                                       |                48625 |      1382622743 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $+uuhfMjnt2pd1GQ1RdrVSGOk2DLX8zl3hG7pGTfLzL4 | @matthew:matrix.org |             |                                                       |                48675 |      1383200947 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $CjwYl6KWQU/ZBW8v3Kht6EunM6XvR3aa0gQ4GXn8amA | @matthew:matrix.org |             |                                                       |                48677 |      1383201213 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $TaNk6LmBCapFID5rXKOlpc69RidyGBlQxIRcBnI7qhY | @matthew:matrix.org |             |                                                       |                49868 |      1389970010 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $gsObK/WLLBMYCNH5gtOlRoe+PryHBLhaU7zkz3RpwMY | @matthew:matrix.org |             |                                                       |                49881 |      1390458776 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $oHDHler5Bk8LfbMTrKCUCgXWBIrISPIl5x9kk4MP5tM | @matthew:matrix.org |             |                                                       |                49888 |      1391394973 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $OrB6RP66DeF6w6PWrTDPSw88EZLsYaUZncmy5qu1eik | @matthew:matrix.org |             |                                                       |                50187 |      1394183406 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $Q0ag5lCj2elsBxsTHjlVi0Cij1nnX2DoZI8T5TcH2DM | @matthew:matrix.org |             |                                                       |                50192 |      1394207118 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $Ea2h3Sz6ecX4rUUOdIgKv2TYP3K3IiIk2PnT1Onm+hk | @matthew:matrix.org |             |                                                       |                50236 |      1394746358 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $3bJV9To0k4rPWLTMduw+aan/bo0XI0z7woBZVMN2ct4 | @matthew:matrix.org |             |                                                       |                50959 |      1401515079 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $VxQP09PSwG96UCtNpO94NPocE0SfMrAVYZRV2wE+eRY | @matthew:matrix.org |             |                                                       |                51519 |      1405712715 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $yGrfM5sxljHb6NhW9/pBWJj/LcWguvpdivwgQzg0Kys | @matthew:matrix.org |             |                                                       |                51903 |      1412330183 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $G+1EOOxIfhJPf3bNJaX+BICsLzG1oTO3aNUssrYY0Fk | @matthew:matrix.org |             |                                                       |                51910 |      1412343405 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $1TifxL+ynMf1xhHfeDRsS6lKSVT5wc62peAnT828UGM | @matthew:matrix.org |             |                                                       |                51966 |      1412428843 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $0SBWsmWQxChnIA6s6mrTsRzJ1906SHwgjCU4m4nnMg0 | @matthew:matrix.org |             |                                                       |                51975 |      1412435112 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $3xQuuQcFP6qzNnSnBvBxCeRgUXY1E+vIHfgewnclghE | @matthew:matrix.org |             |                                                       |                51983 |      1412441626 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $WX/EzMF/LbTkziVl+uR1c/wgNMh1/F45hFNBsZg704w | @matthew:matrix.org |             |                                                       |                51997 |      1412448452 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $rC2F52TLDj/0C0iMKWKv87WidZY31yhRhPBDLVc8GOU | @matthew:matrix.org |             |                                                       |                52000 |      1412449389 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $DhTSF77X1iLYl9ln+ykMDniaGZ0Ylx44gfCKigk+g+I | @matthew:matrix.org |             |                                                       |                52003 |      1412450034 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $PddZcsRhoe9x0Qh2zRSv+W6VjO+EZwQfK4u+jPGUIxI | @matthew:matrix.org |             |                                                       |                52020 |      1412461348 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $nO+fq19JymA0XoXnk3K8hxAWNxPg8CaDmskub8dFP+k | @matthew:matrix.org |             |                                                       |                52022 |      1412463473 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $842I99FaGzFS0Ll5LRSTSjQmkLWt2gu4LsDkeEKrfuQ | @matthew:matrix.org |             |                                                       |                52066 |      1412530482 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $F3BMzTS+46zvzKHjA3AFn4YGYmZtIF9YeKBt4PgR+Q0 | @matthew:matrix.org |             |                                                       |                52071 |      1412534999 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $kR6FsmF/E3BlbX4K428grDBvQ17PR4maDMqNWsu+EGc | @matthew:matrix.org |             |                                                       |                52076 |      1412537390 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $wfiW3NNG1/V+89DMICQOoXa11zBfxGpN3TneqG9XJMY | @matthew:matrix.org |             |                                                       |                52077 |      1412537878 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $HlfJb4ZoVSO5Twj1cbppCjqZfN4c9SX+XitSsqRRCDI | @matthew:matrix.org |             |                                                       |                52079 |      1412541073 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $AuDRFxh6cW/xfxyvTTPxXvrt8ONo68yRHKF4OM7cUeE | @matthew:matrix.org |             |                                                       |                52080 |      1412543703 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $O8SdOn3Oyc8J2NWx2ACbafG44tntfKNBW9FlaHpGd2I | @matthew:matrix.org |             |                                                       |                52084 |      1412546630 |     1 |         1 |       
 !zVpPeWAObqutioiNzB:jki.re | $9xymzCgs6MDOeaeiHYzXzLNcMjvnRUEDl+9WO0a5c38 | @matthew:matrix.org |             | ["notify", {"set_tweak": "highlight", "value": true}] |                52289 |      1413846519 |     1 |         1 |       
(29 rows)

matrix=> select rl.*, e.stream_ordering from receipts_linearized rl join events e using(event_id) where rl.room_id='!zVpPeWAObqutioiNzB:jki.re' and user_id='@matthew:matrix.org';
 stream_id |          room_id           | receipt_type |       user_id       |                   event_id                   |         data          | instance_name | stream_ordering 
-----------+----------------------------+--------------+---------------------+----------------------------------------------+-----------------------+---------------+-----------------
 523014181 | !zVpPeWAObqutioiNzB:jki.re | m.read       | @matthew:matrix.org | $GTE/ZQ3WRYsrBzjQ8eIBK5DKOuZ++IqHF4kyWOxFedk | {"ts": 1591827287799} |               |      1414128751
(1 row)
richvdh commented 2 years ago

(this room is an old "Backend internal", last used June 2020, ftr)

Fizzadar commented 2 years ago

Just ran into this myself - it seems that highlight actions are never cleared out (so the user can scroll through their history?).

clokep commented 2 years ago

Just ran into this myself - it seems that highlight actions are never cleared out (so the user can scroll through their history?).

Highlight actions should be cleared after a month, I think #13118 might have regressed this though? (That would be unrelated to this original issue though.)