Fix remaining uses of deprecated cmp argument in attrs decorators

[ulope]

Description

There are a handful of places left that use the deprecated cmp argument on the attr.s decorator:

• https://github.com/matrix-org/synapse/blob/0a00b7ff14890987f09112a2ae696c61001e6cf1/synapse/events/builder.py#L38
• https://github.com/matrix-org/synapse/blob/d29b71aa50f568c3b951b95f2ea3009292b95630/tests/server.py#L472
• https://github.com/matrix-org/synapse/blob/a7a379006651ea219c2618c0a47e8f4053a9e769/synapse/types.py#L421
• https://github.com/matrix-org/synapse/blob/31b1905e13f84d839f46990d7e63bafe0917dc75/synapse/crypto/keyring.py#L65

These should be fixed.

[clokep]

Any idea what they should be replaced? Would you be willing to make a PR making this change?

[lakshay1121]

Is this issue still open ?

[clokep]

Is this issue still open ?

It looks like some of the instances have been replaced, but not all. I still see:

synapse/crypto/keyring.py:@attr.s(slots=True, frozen=True, cmp=False, auto_attribs=True)
synapse/events/builder.py:@attr.s(slots=True, cmp=False, frozen=True, auto_attribs=True)

9892 was a start on this, but was missing bumping the minimum version of attrs.

[lakshay1121]

okk fine then.