search

matrix-org / sytest

Black-box integration testing for Matrix homeservers
Apache License 2.0
72 stars 55 forks source link

dendrite_sytest.sh always uses postgres #1118

Closed DMRobertson closed 3 years ago

DMRobertson commented 3 years ago

Judging by the buildkite config and from discussion in #synapse-dev:matrix.org we expect dendrite to work with sqlite.

Change dendrite_sytest.sh to only fire off postgres if we need it to. Can probably nick the internals of synapse_sytest.sh.

DMRobertson commented 3 years ago

I was mistaken.

kegan:

there's a POSTGRES env var which controls if sytest tests dendrite in postgres or sqlite which modifies the dendrite config YAML, but likely doesn't touch the database setup code

neilalexander:

The postgres instance still gets set up in sytest even when you run Dendrite in SQLite mode, yeah It just gets left unused

I think you can spot this in the perl by looking for $ENV{'POSTGRES'}. Sorry for the false alarm.