matrix-org / sytest

Black-box integration testing for Matrix homeservers
Apache License 2.0
73 stars 55 forks source link

Make device display name check optional for `federation/v1/user/keys/query` #1311

Closed anoadragon453 closed 2 years ago

anoadragon453 commented 2 years ago

Some homeservers (Synapse) have started omitting device's display name over federation by default. The spec doesn't mandate that this field be available, so Sytest shouldn't either.

This PR modifies the check so that it is optional - only if the field is present do we check the value.

DMRobertson commented 2 years ago

== -> eq (aka fix my mistakes pls)

(Or better: use Rich's formulation)

(Or better better: invent a time machine and prevent perl from being created)