Change expectations of filenameless `Content-Disposition`

matrix-org / sytest

Black-box integration testing for Matrix homeservers

Apache License 2.0

71 stars 55 forks source link

Change expectations of filenameless `Content-Disposition` #1355

Closed reivilibre closed 1 year ago

reivilibre commented 1 year ago

Follows #1353

For the 'no filename' test, SyTest was expecting no Content-Disposition header. Given what we want to achieve, I propose we instead expect a value of attachment (without a filename part).

erikjohnston commented 1 year ago

@reivilibre are the failures because we have a branch on Synapse with the same branch name?

joshqou commented 1 year ago

@erikjohnston @reivilibre Seems to be. Branch isn't up to date with develop, so pre-hotserve pr

reivilibre commented 1 year ago

Silly me not cutting the branch on the latest develop :facepalm: — it passes in https://github.com/matrix-org/synapse/pull/15784 so I'm happy to believe this is OK now.