search

matrix-org / sytest

Black-box integration testing for Matrix homeservers
Apache License 2.0
71 stars 55 forks source link

Update Synapse Admin API quarantine path #1380

Closed anoadragon453 closed 3 months ago

anoadragon453 commented 3 months ago

This path was deprecated nearly 4 years ago in https://github.com/matrix-org/synapse/pull/6681.

anoadragon453 commented 3 months ago

That test failure exists on develop as well, and isn't related to this PR. We should try to fix it separately, however we shouldn't merge this until that test passes, so that we can check this change works.

anoadragon453 commented 3 months ago

The problem is that the Admin API request is going to the main process, whereas it should be going to the media worker. As we disable media functionality, including media-related Admin API functionality, in Sytest's Synapse when workers are enabled:

https://github.com/matrix-org/sytest/blob/7d3f92d4c2083a3efd16ad5c4046f6c91acfc5e8/lib/SyTest/Homeserver/Synapse.pm#L265

https://github.com/element-hq/synapse/blob/1e68b56a623a0d7f98106482bfed223c22193050/synapse/rest/admin/__init__.py#L351-L352

anoadragon453 commented 3 months ago

The problem is that the Admin API request is going to the main process, whereas it should be going to the media worker.

Should be fixed by https://github.com/matrix-org/sytest/pull/1381.