search

matrix-org / vodozemac

An implementation of Olm and Megolm in pure Rust.
Apache License 2.0
175 stars 31 forks source link

Track the number of ratchet advances in the Olm Session, and include it in the debug output. #134

Closed richvdh closed 7 months ago

richvdh commented 7 months ago

In order to help understand Olm decryption errors, let's keep track of the number of DH ratchet clicks, and log them as part of the debug output.

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 84.65%. Comparing base (7a1887f) to head (5599cef). Report is 1 commits behind head on main.

Files Patch % Lines
src/olm/session/double_ratchet.rs 81.81% 4 Missing :warning:
src/olm/session/receiver_chain.rs 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #134 +/- ## ========================================== - Coverage 84.72% 84.65% -0.08% ========================================== Files 32 32 Lines 1768 1786 +18 ========================================== + Hits 1498 1512 +14 - Misses 270 274 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

richvdh commented 7 months ago

@poljar: have added some tests. Let me know what you think. Happy to add more if you have suggestions.