matrix-org / vodozemac

An implementation of Olm and Megolm in pure Rust.
Apache License 2.0
175 stars 30 forks source link

ci: Split out the CI setups for mutation testing #152

Closed poljar closed 6 months ago

poljar commented 6 months ago

This patch attempts to limit the times we run the full mutation tests. The full tests take 1h to complete so it's not feasible to run them as part of a pull-request CI job.

The original setup did attempt to limit this as well, but pushing additional commits to a pull request did trigger the full run as well.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.37%. Comparing base (3b1ac68) to head (ceb0ce2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #152 +/- ## ========================================== + Coverage 90.32% 90.37% +0.05% ========================================== Files 32 32 Lines 1788 1787 -1 ========================================== Hits 1615 1615 + Misses 173 172 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Urgau commented 5 months ago

Heads up, with the release of rust-lang/cargo#13913 (in nightly-2024-05-19). Cargo has now gain the ability to declare --check-cfg args directly inside the [lints] table with [lints.rust.unexpected_cfgs.check-cfg][^1]:

Cargo.toml:

[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(fuzzing)'] }

Note that the diagnostic output of the lint has been updated to suggest the [lints] approach first. You can use it to guide you through the --check-cfg arguments that may need to be added.

[^1]: take effect on Rust 1.80 (current nightly), is ignored on Rust 1.79 (current beta), and produce an unused warning below

poljar commented 5 months ago

Heads up, with the release of rust-lang/cargo#13913 (in nightly-2024-05-19). Cargo has now gain the ability to declare --check-cfg args directly inside the [lints] table with [lints.rust.unexpected_cfgs.check-cfg]1:

Ah nice, thanks for letting us know.