matrix-org / vodozemac

An implementation of Olm and Megolm in pure Rust.
Apache License 2.0
155 stars 29 forks source link

Clarify status of backup implementation #155

Closed Johennes closed 4 months ago

Johennes commented 4 months ago

In a chat with @ara4n yesterday I learnt that the legacy backup has actually been implemented in matrix-sdk-crypto and isn't planned to be added here anymore. I suppose MSC4048 will be implemented there, too, then which is why I have removed its reference as well.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.56%. Comparing base (4ef989c) to head (7b3e5f7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #155 +/- ## ======================================= Coverage 90.56% 90.56% ======================================= Files 34 34 Lines 1908 1908 ======================================= Hits 1728 1728 Misses 180 180 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dkasak commented 4 months ago

We avoided implementing primitives for the existing backup in vodozemac because the design is known to be flawed. Therefore, in my opinion it's not a given that none of the improved design (MSC4048) will end up in vodozemac. The deciding factor for that should be whether something is a "primitive" or foundational cryptographic construct, in which case it belongs in vodozemac, or if it is more of a Matrix layer feature, in which case it should be part of matrix-sdk-crypto.

Johennes commented 4 months ago

Ah, I see. Thanks for clarifying.