search

matrix-org / vodozemac

An implementation of Olm and Megolm in pure Rust.
Apache License 2.0
175 stars 30 forks source link

refactor: Remove the pkcs7 crate from the list of dependencies #164

Closed poljar closed 3 months ago

poljar commented 3 months ago

The pkcs7 crate has been deprecated^1, the authors recommend us to switch to the block_padding crate instead.

Incidentally we're already using the block_padding crate for our pkcs7 needs as that one is re-exported by the AES crate. This means that the pkcs7 crate is already an unused dependency and we can just remove it.

This has been confirmed by cargo-udeps^2 as well.

This closes: #162.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@abe6b62). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #164 +/- ## ======================================= Coverage ? 90.55% ======================================= Files ? 34 Lines ? 1905 Branches ? 0 ======================================= Hits ? 1725 Misses ? 180 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.