search

matrix-org / vodozemac

An implementation of Olm and Megolm in pure Rust.
Apache License 2.0
155 stars 29 forks source link

Add pickling logic to pk_encryption #173

Closed devonh closed 1 week ago

devonh commented 1 month ago

This is an attempt to add pickling to the new pk_encryption work. #171 I am not very familiar with this codebase, but I took my best attempt at implementing the functionality based on how the legacy libolm Account pickling works.

The tests are passing against the olm_rs impl which gives me some confidence in it.

poljar commented 1 week ago

Oh my, this got auto-closed because the base branch got auto-deleted. Could you reopen it with a different base?

devonh commented 1 week ago

Oh my, this got auto-closed because the base branch got auto-deleted. Could you reopen it with a different base?

haha yeah no problem. I'll open it against main now

poljar commented 1 week ago

Oh my, this got auto-closed because the base branch got auto-deleted. Could you reopen it with a different base?

haha yeah no problem. I'll open it against main now

Thanks.

devonh commented 1 week ago

Oh my, this got auto-closed because the base branch got auto-deleted. Could you reopen it with a different base?

haha yeah no problem. I'll open it against main now

Thanks.

Hmm, it seems like I might not have enough permissions to be able to reopen a PR. Are you able to reopen it?

Otherwise I have to create a whole new PR.

poljar commented 1 week ago

I am not able to reopen it either :sweat_smile:. I can't reopen it because the base branch was deleted and I can't change the base branch...

devonh commented 1 week ago

Haha what a pickle :P I can just create a new PR then