search

matrix-org / waterfall

A cascading stream forwarding unit for scalable, distributed voice and video conferencing over Matrix
Apache License 2.0
98 stars 5 forks source link

Do not hangup in `onConnectionStateChanged()` #114

Closed SimonBrandner closed 1 year ago

daniel-abramov commented 1 year ago

Sorry @SimonBrandner, I'm missing a bit of a context. Why don't we want to hang up on a disconnect? (I could assume that it's because of the reconnect that would be expected on the client side?)

SimonBrandner commented 1 year ago

Sorry @SimonBrandner, I'm missing a bit of a context. Why don't we want to hang up on a disconnect? (I could assume that it's because of the reconnect that would be expected on the client side?)

In the js-sdk we never send a hangup event in the case where connectionstatechange is fired, so we're assuming that we fire it incorrectly here. From trying to understand the documentation we gathered that we might be able to recover from disconnected and we've removed it here.

Further context: https://matrix.to/#/!dXHEZfLxIQzAELxzQd:matrix.org/$JJmHD9GTUZjmVLERRHZhDpoSXPMXqgcAeiVzpYKzB0Q?via=matrix.org&via=element.io&via=one.ems.host (and messages below)

daniel-abramov commented 1 year ago

Makes sense, thanks!