search

matrix-org / waterfall

A cascading stream forwarding unit for scalable, distributed voice and video conferencing over Matrix
Apache License 2.0
97 stars 5 forks source link

rewriter: add vp8 keyframe detection function #140

Closed daniel-abramov closed 1 year ago

daniel-abramov commented 1 year ago

We've postponed working on https://github.com/matrix-org/waterfall/issues/100

The branch I started more than a month ago is obsolete and does not compile anymore (due to conflicts caused by changes done in the previous PRs). Still, the function for the detection of VP8 frames is somewhat isolated and does not really have any dependencies, so I decided to file the PR with this small function so that I can remove the now obsolete branch while preserving something that could be reused by one who works on the issue in the future.

daniel-abramov commented 1 year ago

I am not sure how big of a fan of dead code I am but this seems okayish

I'm with you on that 🙂