Fix issues with the heartbeat logic on the server - Githubissues

matrix-org / waterfall

A cascading stream forwarding unit for scalable, distributed voice and video conferencing over Matrix

Apache License 2.0

97 stars 5 forks source link

Fix issues with the heartbeat logic on the server #80

Closed daniel-abramov closed 1 year ago

daniel-abramov commented 1 year ago

Per-commit review is required (one fix - one comment with an explanation).

Summary:

Fixed memory leak caused by Ticker() in the heartbeat.
Fixed heartbeat not assuming that pings can fail (data channel may be closed for instance).
Fixed wrong comparison in config validation (that mandated interval being 30+ seconds and not 30- seconds as per MSC).
Remove confusing (duplicate) logs (and make less relevant ones debug).