matrix-profile-foundation / matrixprofile

A Python 3 library making time series data mining tasks, utilizing matrix profile algorithms, accessible to everyone.
https://matrixprofile.org
Apache License 2.0
362 stars 62 forks source link

Python 3.9 Binary Wheels for Linux and MacOS #68

Closed tylerwmarrs closed 3 years ago

tylerwmarrs commented 3 years ago

Our wheel build system is reliant on the package cibuildwheel. Currently, our TravisCI script has some environment issues with Python and pulling down the required version of cibuildwheel for Python 3.9 support. The version required for cibuildwheel to build wheels on Python 3.9 is v1.6.2.

See these logs for Linux and MacOS issues:

https://travis-ci.com/github/matrix-profile-foundation/matrixprofile/jobs/464939617 https://travis-ci.com/github/matrix-profile-foundation/matrixprofile/jobs/464939618

Windows is successfully building wheel for Python 3.9.

tylerwmarrs commented 3 years ago

This is fixed for Linux. I need a MacOS user to assist with the appropriate commands to install Python 3.8. @vanbenschoten are you able to assist here or @frankiecancino ?

Basically, I need to know how to get this to work:

brew install python@3.8                                                 
brew upgrade python@3.8                                                 
brew link --force python@3.8 

My readings online show that this should install Python 3.8 and link it as the default. Can one of you test and let me know the result?

The build log shows that this keg does not exist:

https://travis-ci.com/github/matrix-profile-foundation/matrixprofile/jobs/464949793#L1967

vanbenschoten commented 3 years ago

@frankiecancino can you help here? I don't have a Mac any more.

On Sat, Dec 26, 2020, 1:59 PM Tyler Marrs notifications@github.com wrote:

This is fixed for Linux. I need a MacOS user to assist with the appropriate commands to install Python 3.8. @vanbenschoten https://github.com/vanbenschoten are you able to assist here or @frankiecancino https://github.com/frankiecancino ?

Basically, I need to know how to get this to work:

brew install python@3.8 brew upgrade python@3.8 brew link --force python@3.8

My readings online show that this should install Python 3.8 and link it as the default. Can one of you test and let me know the result?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/matrix-profile-foundation/matrixprofile/issues/68#issuecomment-751390796, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB53ISAWZWYY3AWBE5PQF4DSWY6CJANCNFSM4VKEQJ5A .

frankiecancino commented 3 years ago

For which Python version? @tylerwmarrs you mentioned issues with Python 3.9 in the first comment, but Python 3.8 in the second comment.

tylerwmarrs commented 3 years ago

3.8 is a baseline version for cibuildwheel, a package used for building binary python wheels, to be able to build version 3.9 binary wheels of matrixprofile. You can use 3.8 or 3.9 to provide feedback. Please look at the latest commits to the TravisCI for some clarity if needed.

On Mon, Jan 4, 2021, 9:22 PM Frankie Cancino notifications@github.com wrote:

For which Python version? @tylerwmarrs https://github.com/tylerwmarrs you mentioned issues with Python 3.9 in the first comment, but Python 3.8 in the second comment.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/matrix-profile-foundation/matrixprofile/issues/68#issuecomment-754364798, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMYFM2BR5CUCPSTCURHQ5DSYKAXXANCNFSM4VKEQJ5A .

jacksongreen28 commented 3 years ago

I was able to successfully get python 3.8 working using the commands above except for the final one. Here is the command I used:

brew link --overwrite python@3.8

This should create the symlinks

tylerwmarrs commented 3 years ago

This is still an issue. I cannot seem to resolve it. The issue that I'm having is that when I try to make Python 3.8 as the default python version, cibuildwheel still tries to use Python 2.7 making it not work with the required version of cibuildwheel for building Python 3.9.

tylerwmarrs commented 3 years ago

MacOSx is now building successfully against Python 3.5 to 3.9!!!!!!!