search

matrix-profile-foundation / matrixprofile

A Python 3 library making time series data mining tasks, utilizing matrix profile algorithms, accessible to everyone.
https://matrixprofile.org
Apache License 2.0
362 stars 62 forks source link

Strict dependency on protobuf 3.11.2 #75

Closed burk closed 3 years ago

burk commented 3 years ago

Describe the bug

There still seems to be a strict dependency on protobuf 3.11.2, even though this commit seems to try to remove that strict version dependency: https://github.com/matrix-profile-foundation/matrixprofile/commit/37173af1904e761bda509de41cd4cfbeacf23fcd

I'm not able to lock the version of matrixprofile inside a pipenv with another library which requires protobuf >= 3.12.0

To Reproduce Steps to reproduce the behavior:

  1. Download the latest Python 3.8 matrixprofile linux wheel.
  2. Unzip it.
  3. Look inside the file matrixprofile-1.1.10.dist-info/METADATA
  4. Observe the line Requires-Dist: protobuf (==3.11.2)

Desktop (please complete the following information):

burk commented 3 years ago

I've identified the problem: https://github.com/matrix-profile-foundation/matrixprofile/pull/76

vanbenschoten commented 3 years ago

@burk Thanks for the PR! Apologies as I've been a little delayed - I'll look at the change shortly.

vanbenschoten commented 3 years ago

Corresponding PR approved and merged. Thanks!

alexvorobiev commented 3 years ago

Pypi version still has this restriction.