search

matrix-profile-foundation / matrixprofile

A Python 3 library making time series data mining tasks, utilizing matrix profile algorithms, accessible to everyone.
https://matrixprofile.org
Apache License 2.0
360 stars 62 forks source link

Comparison to constants should use `==` not `is` #81

Closed Spriithy closed 3 years ago

Spriithy commented 3 years ago

Hi,

In accordance to Python's ways of comparing values, matrixprofile should comply with using == instead of is for such expressions.

This is issue came up with a SyntaxWarning when packaging a project using PEX.

Anyways, this is a costless fix that would fix this.

Thanks in advance.

codecov[bot] commented 3 years ago

Codecov Report

Merging #81 (3ba4812) into master (cf342ba) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files          31       31           
  Lines        2318     2318           
=======================================
  Hits         2137     2137           
  Misses        181      181
Impacted Files Coverage Δ
matrixprofile/algorithms/stomp.py 96.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cf342ba...3ba4812. Read the comment docs.

vanbenschoten commented 3 years ago

Thanks @Spriithy! I'll take a quick look in a bit. Much appreciated!

vanbenschoten commented 3 years ago

@Spriithy apologies for the delay - finally merging. Thanks for the PR!