search

matrixorigin / matrixone

Hyperconverged cloud-edge native database
https://docs.matrixorigin.cn/en
Apache License 2.0
1.71k stars 268 forks source link

[Tech Request]: Fix the processing of hexadecimal literals #13493

Open aunjgr opened 7 months ago

aunjgr commented 7 months ago

Is there an existing issue for the same tech request?

Does this tech request not affect user experience?

What would you like to be added ?

The current implementation parses hexadecimal literals as a string with isBin flag. That flag is even passed to Vector.

It's a bug-prone and intrusive design. ~It causes the "double-binarization" bug in matrixorigin/MO-Cloud#2030.~

We should rewrite it in a better way. All hexadecimal literals should be recognized and stored as a hexnum Literal in the first place, then converted to unsigned integer or binary string according to the target type later. The isBin flag should to eliminated.

Why is this needed ?

No response

Additional information

No response

aunjgr commented 7 months ago

It's not the cause of matrixorigin/MO-Cloud#2030 now.