While reading through the code behind this framework to gain a better understanding of how it was implemented (I learned a lot), I was intrigued to read through the tests after I've heard @matryer wax lyrical about test driven development in Go. 🤓
I couldn't help but notice a few small nitpicks in the test cases I wanted to suggest fixing. Mostly the changes are to comments/error messages but one change updates a test that I believe might have been the result of a copy/paste error on line 81 in is_test.go. 👈
Note: I would've opened an issue for this but felt that it was a small enough change to just open a pull request. I couldn't find any contributing guidelines, so happy to link to an issue if you'd like me to do so. 🙂
While reading through the code behind this framework to gain a better understanding of how it was implemented (I learned a lot), I was intrigued to read through the tests after I've heard @matryer wax lyrical about test driven development in Go. 🤓
I couldn't help but notice a few small nitpicks in the test cases I wanted to suggest fixing. Mostly the changes are to comments/error messages but one change updates a test that I believe might have been the result of a copy/paste error on line 81 in
is_test.go. 👈Note: I would've opened an issue for this but felt that it was a small enough change to just open a pull request. I couldn't find any contributing guidelines, so happy to link to an issue if you'd like me to do so. 🙂