Added handling/tests for return slice on variadic method

matryer / moq

Interface mocking tool for go generate

http://bit.ly/meetmoq

MIT License

2k stars 127 forks source link

Added handling/tests for return slice on variadic method #100

Closed pehowell closed 4 years ago

pehowell commented 5 years ago

Let me know if you want me to handle identifying variadic params to extractArgs() in a different way, thanks!

This fixes #99

pehowell commented 5 years ago

Hi @matryer, looks like the failures are because newer versions of tools/go/packages dropped support for go versions < 1.11. I can think of a couple of options here:

moq drops support for 1.10 and below, so I can update the travis file to test 1.11, 1.12, and tip. This would also allow adding go module support in the future.
moq uses dep or some other means to pin it to a specific version of package

My vote is for the first option, but what does everyone else think?

breml commented 5 years ago

I am fine with option 1. This is also in accordance with the Go release policy.

pehowell commented 5 years ago

@breml thanks for the feedback. I've removed 1.9 and 1.10 testing environments and added 1.12.

sudo-suhas commented 4 years ago

Hey @pehowell thanks for this. The issue is now fixed via #126 so I am closing this PR.