search

matryer / moq

Interface mocking tool for go generate
http://bit.ly/meetmoq
MIT License
2k stars 127 forks source link

Declare working dependency version with go.mod #101

Closed tylerchr closed 4 years ago

tylerchr commented 5 years ago

Some sort of incompatibility was introduced between moq and whatever version of golang.org/x/tools/go/packages I happened to have in my $GOPATH that resulted in moq failing with odd errors (see #98).

I was able to fix this by updating my copy of the dependency to the current version, though it took a bit for me to think to do that. Adding a go.mod file will ensure that builds of mod are done against a working version of golang.org/x/tools/go/packages, especially in Go 1.13+ which will have modules on by default.

Resolves #98.

tylerchr commented 5 years ago

Ideally, should this change be merged, the resultant commit would be tagged with a version tag like v1.0.0.

johanbrandhorst commented 5 years ago

What's blocking this at the moment?

sudo-suhas commented 4 years ago

Thank you @tylerchr for the PR but I had to make a few more changes to migrate to Go modules and did so in #135.