search

matryer / moq

Interface mocking tool for go generate
http://bit.ly/meetmoq
MIT License
2k stars 127 forks source link

Universal binaries for macOS #159

Closed sudo-suhas closed 3 years ago

sudo-suhas commented 3 years ago

A special format that contains both arm64 and amd64 executables in a single file.

sudo-suhas commented 3 years ago

https://goreleaser.com/customization/universalbinaries/

sudo-suhas commented 3 years ago

@matryer @breml please share your feedback if you have any. Will merge this change in in a few days if there are no concerns raised.

breml commented 3 years ago

@sudo-suhas I am not a mac user, so I can not test this, sorry. But as far as I can tell, the PR looks good to me.

sudo-suhas commented 3 years ago

Thanks @breml. There is one aspect that I would appreciate feedback on. Fat binaries, as the name suggests, are large in size since they contain binaries targeting both architectures. Currently, I am opting to publish fat as well as architecture-specific binaries so that if someone wishes to download the more specific smaller size binary, they can. Would you agree with this choice?

breml commented 3 years ago

Yes, this sounds good to me.

sudo-suhas commented 3 years ago

Changes released in v0.2.4 🎉