search

matryer / moq

Interface mocking tool for go generate
http://bit.ly/meetmoq
MIT License
2k stars 127 forks source link

fix: bump xtools to 0.1.9 to support go 1.18 #167

Closed tprebs closed 2 years ago

tprebs commented 2 years ago

Resolves #166

slagiewka commented 2 years ago

You basically beat me by minutes to that.

Why 0.1.9? There's 0.1.10 already that's been released just yesterday. I have successfully tested mock generation with 0.1.10 in my 1.18 project.

sudo-suhas commented 2 years ago

In addition to what @slagiewka mentioned, could we also please update the CI configuration to test on go 1.17 and 1.18? Relevant file - https://github.com/matryer/moq/blob/v0.2.5/.github/workflows/test.yml#L17-L23

tprebs commented 2 years ago

You basically beat me by minutes to that.

Why 0.1.9? There's 0.1.10 already that's been released just yesterday. I have successfully tested mock generation with 0.1.10 in my 1.18 project.

Ah! I missed the 0.1.10 release yesterday. I have bumped the version.

addition to what @slagiewka mentioned, could we also please update the CI configuration to test on go 1.17 and 1.18? Relevant file

I have added 1.17 and 1.18 to the matrix. Is there any reason we don't run 1.14.x on windows or macos? If we need to exclude mac/windows from 1.14 then it makes more sense to add windows and macos to the matrix and exclude windows and macos for 1.14

slagiewka commented 2 years ago

I have added 1.17 and 1.18 to the matrix. Is there any reason we don't run 1.14.x on windows or macos? If we need to exclude mac/windows from 1.14 then it makes more sense to add windows and macos to the matrix and exclude windows and macos for 1.14

I can't read that out from history of this repository so I'm not sure either.

I'm also not sure if that was Suhas' idea here, but maybe this project should now test ONLY against 1.17 and 1.18? That would be in line with Go release policy.