matryer / silk

Markdown based document-driven RESTful API testing.
http://silktest.org/
GNU General Public License v2.0
942 stars 69 forks source link

Markdown file length or assertions limit? #41

Closed rafavisa closed 8 years ago

rafavisa commented 8 years ago

Is there any length limit for the .md file? Or any limitations in the number of asserts?

I am having some test failures due to .md parsing. invalid request: net/http: invalid method "a@st" \ This is not what the .md files contains.

I can reproduce it by replicating a simple test that pass in the same file for several times. When I try to run exactly the same test for 6-7 times.

Any known issue?

Thanks

antekresic commented 8 years ago

Take a look in issue #39, smells like the same issue.

rafavisa commented 8 years ago

I've tried building last merge from today (https://github.com/matryer/silk/commit/3ebbb58911746ada50919f86fd6c601647dcf2dc) and I can reproduce the issue.

You can do it ie. by running a file that contains 15+ example tests like this one (https://github.com/matryer/silk/blob/master/examples/real/hello-api.silk.md)

The error in this case will be: === RUN silk running 1 file(s)... Get http://outlearn-hello.appspot.com a per invalid request: parse http://outlearn-hello.appspot.com a per: invalid character " " in host name

antekresic commented 8 years ago

I see. I wasn't able to reproduce your issue by using that example file. Any chance you can setup a gist with a Silk file and unit test that generates this issue? It would make it so much easier to check what is going on there.

Thanks.

rafavisa commented 8 years ago

Can you reproduce it with https://gist.github.com/rafavisa/f2890eb897f6441aed9f746600854b67 ?

antekresic commented 8 years ago

OK, I see the issue now. I'll take a look.

rafavisa commented 8 years ago

Thank you!

antekresic commented 8 years ago

Are you sure you are updating the code? I'm getting the same exact issue when using the code before the last merge and no issue after the merge (3ebbb58).

Can you try removing the repo from your GOPATH dir and doing go get github.com/matryer/silk?

rafavisa commented 8 years ago

You are right, it is fixed now.

Thanks!

antekresic commented 8 years ago

Awesome! Can you close this issue if its fixed?

Thanks.