search

matryer / vice

Go channels at horizontal scale (powered by message queues)
https://medium.com/@matryer/introducing-vice-go-channels-across-many-machines-bcac1147d7e2
Apache License 2.0
1.55k stars 79 forks source link

some messages might get dropped due to buffered channels #15

Closed HeavyHorst closed 7 years ago

HeavyHorst commented 7 years ago

We use buffered channels for the sender in some queue implementations (nats, redis, sqs). This increases the performance a lot (#12) but if we stop the transport we might leave some messages in this channel without sending them to the message queue.

Should we flush all remaining messages to the queue if we call Stop() ?

matryer commented 7 years ago

Yes we should... question is, how?

HeavyHorst commented 7 years ago

I've got something working for nats: #20

matryer commented 7 years ago

Opened issues for the other implementations.