search

matryer / vice

Go channels at horizontal scale (powered by message queues)
https://medium.com/@matryer/introducing-vice-go-channels-across-many-machines-bcac1147d7e2
Apache License 2.0
1.54k stars 79 forks source link

Redis queue imports fail - gopkg.in is not supported any longer #52

Closed wmccracken closed 2 years ago

wmccracken commented 5 years ago

The redis Transport is currently failing:

vendor/gopkg.in/redis.v3/cluster.go:17:2: use of internal package github.com/xx/yy/vendor/github.com/go-redis/redis/internal not allowed vendor/gopkg.in/redis.v3/ring.go:14:2: use of internal package github.com/xx/yy/vendor/github.com/go-redis/redis/internal/consistenthash not allowed vendor/gopkg.in/redis.v3/cluster.go:18:2: use of internal package github.com/xx/yy/vendor/github.com/go-redis/redis/internal/hashtag not allowed vendor/gopkg.in/redis.v3/cluster.go:19:2: use of internal package github.com/xx/yy/vendor/github.com/go-redis/redis/internal/pool not allowed vendor/gopkg.in/redis.v3/cluster.go:20:2: use of internal package github.com/xx/yy/vendor/github.com/go-redis/redis/internal/proto not allowed vendor/gopkg.in/redis.v3/cluster.go:21:2: use of internal package github.com/xx/yy/vendor/github.com/go-redis/redis/internal/singleflight not allowed

This appears to be related to https://github.com/go-redis/redis/issues/665

Updating the imports to github.com/go-redis/redis corrected the issue for me. I'll submit a PR shortly.

ojizero commented 2 years ago

@wmccracken this should be fixed both in the patched version of Vice 1 (#54) as well as Vice V2. Will close this for now, please feel free to update me if you still face any other issues with it!