matryer / vice

Go channels at horizontal scale (powered by message queues)
https://medium.com/@matryer/introducing-vice-go-channels-across-many-machines-bcac1147d7e2
Apache License 2.0
1.54k stars 79 forks source link

context.Context friendly API #59

Open harry-xm opened 3 years ago

harry-xm commented 3 years ago

https://github.com/matryer/vice/blob/660007f4486b289078664b182d1ecd2a22b29b02/transport.go#L24

Done() in context.Context returns a <-chan struct{}, which is not compatible with vice.Transport.

    *Transport does not implement vice.Transport (wrong type for Done method)
        have Done() <-chan struct {}
        want Done() chan struct {}