matryer / xbar-plugins

Plugin repository for xbar (the BitBar reboot)
https://xbarapp.com
2.45k stars 1.04k forks source link

001-airconnect.1d.sh: Updates for Apple silicon #2058

Open cuprousoxide opened 2 months ago

cuprousoxide commented 2 months ago

fao @cartoonchess -

Looks like the default process name has changed from aircast-osx-multi to aircast-macos. Also, line 75 has said process name hardcoded in a grep instead of referring to the processName variable defined up top by the user. I'd do a PR myself for those two little items, but I also had to add a line to export my DYLD_LIBARY_PATH otherwise I get an error about libcrypto and the plugin doesn't actually work. It's my understanding this has to do with Homebrew putting packages somewhere different on Apple silicon (which I use). I'm a layman and not a developer and I'm not sure what the best practice is for handling Intel vs Apple issues like this other than adding a line for m* chip users to uncomment?

sprak3000 commented 2 months ago

@cuprousoxide

You might need to set the shebang to include both the M* silicon and not. Here is an example from a recent open PR:

#!/usr/bin/env -S PATH="${PATH}:/opt/homebrew/bin:/usr/local/bin" php

The -S PATH="" sets up the script's path to include /opt/homebrew/bin for M* silicon and /usr/local/bin for older machines.