Closed iosdeveloper closed 7 years ago
The problem with this approach is what about plugins that have dependancies? The
# <bitbar.demo>brew install xyz; pip install python-doessomething;etc</bitbar.demo>
I'm not sure that's the best way to handle it...
demo
contains any arguments that are passed to the plugin by BitBar when executing. I didn't consider dependencies but couldn't the plugin handle the installation when it detects that it is in demo mode?
Full example: https://github.com/iosdeveloper/ScreenshotTest/blob/master/Plugins/cycle_text_and_detail.sh
In my opinion, on a pull request we should:
Otherwise (no PR) it should only take a screenshot if the image tag is missing or invalid.
I wrote a proof of concept in bash here: https://github.com/iosdeveloper/ScreenshotTest/blob/master/screenshot.sh Travis CI build looks like this: https://travis-ci.org/iosdeveloper/ScreenshotTest/builds/123342526 Results with the example above: https://i.imgur.com/3xZVato.png https://i.imgur.com/7ktGXHe.png