search

matryer / xbar-plugins

Plugin repository for xbar (the BitBar reboot)
https://xbarapp.com
2.46k stars 1.04k forks source link

re: PagerDuty Incidents #708

Closed parabuzzle closed 7 years ago

parabuzzle commented 7 years ago

FAO: (@pedrofuentes) I've tested that my token works against the api but I'm getting this error:

(node:11322) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
(node:11322) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
parabuzzle commented 7 years ago

It appears that this plugin doesn't support the PagerDuty V2 api. In order to fix this, I generated a V1 key and it seems to work now. That should be documented somewhere.

matryer commented 7 years ago

We’d love a PR since you know the issue?

On 28 Feb 2017, at 14:27, Mike Heijmans notifications@github.com wrote:

It appears that this plugin doesn't support the PagerDuty V2 api. In order to fix this, I generated a V1 key and it seems to work now. That should be documented somewhere.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/matryer/bitbar-plugins/issues/708#issuecomment-283052858, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGNG2NyAjiYCEN5YAl05NQ8cZse6izcks5rhC67gaJpZM4MNgzm.

pedrofuentes commented 7 years ago

Thank @parabuzzle,

I have documentation on my repo but I did not clarify there that a v1 API key was needed, I just fixed it.

I also plan at some point to migrate to v2, contributions are welcome.

parabuzzle commented 7 years ago

good enough for me :)

pedrofuentes commented 5 years ago

@parabuzzle I just updated the code to work with PagerDuty v2 API