matryer / xbar

Put the output from any script or program into your macOS Menu Bar (the BitBar reboot)
https://xbarapp.com
MIT License
17.55k stars 643 forks source link

Any chance for 10.13 support? (last version to use Nvidia GPUs) #611

Closed Joshfindit closed 3 years ago

Joshfindit commented 3 years ago

xbar looks awesome, but I just went to run it and it's only macOS 11+ 😥

image

matryer commented 3 years ago

@Joshfindit I'll see what the minimum os we can get away with it, and let you know.

ianfoo commented 3 years ago

This is an interesting dialog, because it tells a falsehood about requiring macOS 11, as someone who is running xbar on Catalina (macOS 10.15.7).

matryer commented 3 years ago

@Joshfindit Does this do the same? xbar.v2.0.19-beta-5-g9a866463.tar.gz

beaudett commented 3 years ago

Hi. My mac is running 10.14.6 and I can start the above version of xbar from command line. From the Finder it doesn't start saying that I have macOS 10.14.16 and the application requires 10.13 or later.

beaudett commented 3 years ago

I am sorry to say that with v2.0.25-beta it shows: Screenshot 2021-03-12 at 13 30 02 and it also breaks from the command line:

xbar v2.0.25-beta application requires at least OS X version 10.15.0 (10.15.0), but is being run on 10.14.6 ( 10.14.6/18G8022), and so is exiting.SIGABRT: abort PC=0x7fff58bb72c2 m=0 sigcode=0 signal arrived during cgo execution

Thank you so much for your efforts !

matryer commented 3 years ago

@beaudett thanks for trying it. I'm just trying to different values, for the build tools - even if it lets you run it, it doesn't mean the app will work as expected. Please try this one.

Here's one with 10.13 set as the minimum version: xbar.v2.0.25-beta-1-g8d8f34f1.tar.gz

beaudett commented 3 years ago

Indeed, it works, both from the Finder and from command line ! Thank you !

matryer commented 3 years ago

@beaudett ok so from the next major release, v2.0.26-beta and above, it should work normally for you. Please report any other issues you have. If we're lucky, we can support 10.13 without too much maintenance overhead.

matryer commented 3 years ago

@leaanthony We'll leave 10.15 on the README for now, but if the app runs fine on older operating systems, I see no reason not to support them.

Joshfindit commented 3 years ago

Confirmed it works fine for me too. Installed plugins from the browser, have realtime readout in the menubar.

Thank you!

matryer commented 3 years ago

@Joshfindit That's great, thanks for letting me know. You'll two will need to be our testers, we don't have computers that can run that operating system. :)

Joshfindit commented 3 years ago

@matryer Ping me any time

beaudett commented 3 years ago

Hi @matryer I just tried v2.0.31-beta on MacOS 10.14.6 and I get a crash. The printout can be found here.

matryer commented 3 years ago

Is it reproducible? If so, can you describe the steps?

It’s likely we’re using an API that isn’t supported in that version. We’re targeting 10.15 but would still like to fix this if we can.

On Fri, 19 Mar 2021 at 14:52, Florian Beaudette @.***> wrote:

Hi @matryer https://github.com/matryer I just tried v2.0.31-beta on MacOS 10.14.6 and I get a crash. The printout can be found here https://gist.github.com/beaudett/56137662412402576feecdad74ddd5c7.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/matryer/xbar/issues/611#issuecomment-802890949, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAY2GZEZECVCWMHTSP65GDTENQMVANCNFSM4YZZIIWA .

beaudett commented 3 years ago

Yes, it is 100% reproducible. It is the version from the tarfile from the release page. If I click on the xbar icon in the Finder, nothing happens. From the terminal, I just run ./xbar.app/Contents/MacOS/xbar and I get the crash and the printout mentioned earlier. It seems to be a change introduced between xbar.v2.0.27-beta-17 and xbar.v2.0.28-beta that is causing the problem as the former is running fine and the latter has a sigv that looks similar to the one I shared (at least to me). Thanks a lot for your help !

Joshfindit commented 3 years ago

I am able to successfully run v2.0.32-beta on 10.13.6

One thing that might be the issue: I've had crashes with certain plugins. Move everything out from ~/Library/Application Support/xbar/plugins/ and try opening xbar again.

Check https://github.com/matryer/xbar-plugins/issues/1567 if that fixes it

Joshfindit commented 3 years ago

To be thorough, I just ran xbar.v2.0.31-beta.tar.gz and it also works successfully.

beaudett commented 3 years ago

Hi @Joshfindit. Thanks for the hint ! If I remove my home-made plugins, xbar starts successfully, including xbar.v2.0.31-beta. I'll do my homework and try to fix them.

Joshfindit commented 3 years ago

@beaudett We've found that it's the color= that's causing it to crash on 10.13. I've personally just removed the color directives from all the scripts I use and no more crashes. There's further discussion on https://github.com/matryer/xbar-plugins/issues/1567 if you want to join in.