search

matsadler / magnus

Ruby bindings for Rust. Write Ruby extension gems in Rust, or call Ruby from Rust.
https://docs.rs/magnus/latest/magnus/
MIT License
682 stars 35 forks source link

Rename free_immediatly to free_immediately #31

Closed ankane closed 2 years ago

ankane commented 2 years ago

Fixes typo: immediatly -> immediately

It may make sense to do this in a backwards compatible way if the next release won't be a minor one.

ankane commented 2 years ago

Looks like the test failure is unrelated (same failure happened in the latest main commit).

matsadler commented 2 years ago

Thanks for this!

I fixed this here: https://github.com/matsadler/magnus/commit/854725be45d88ca4fa28dbbb67dfaefacb26298a

Hard cutting over from free_immediatly to free_immediately gives a bunch of horrible compiler errors, with the actual error hurried among them, so I wanted to make the change in a backwards compatible way.

I dusted off an old change to the proc macros that I hadn't got around to merging, and after switching from free_immediatly to free_immediately added free_immediatly as an alias of free_immediately.

Unfortunately it's not possible to generate a depreciation warning from a macro, so I might end up supporting free_immediatly indefinitely, but at least anyone starting from now can use the correct spelling.

The test failure was GitHub updating the Xcode on their macOS runners. Turns out Xcode 14 and Rust 1.51 (the min supported Rust version for this library) don't play well with each other. Looks like something else has broken on Windows, but that's par for the course. I'll figure that out another day.

ankane commented 2 years ago

Great, thanks @matsadler!