Closed matsavage closed 9 months ago
@PJBrs I have created a branch on this issue and pushed the template to it:
@PJBrs I have completed the work on moving the template into separate files, would you be able to have a go at lining up the text boxes for the spells and colour switches for the proficiency markers.
Tip for the lining up is determine the position of the first box, then use the fixed offset to calculate the positions of the others.
Hmmm... The locations of the various boxes seems rather precise... Would there be any way to have that same precision, based on the original halfcaster sheet?
Nevermind, I think the numbers are pretty round --> https://github.com/PJBrs/DND-5e-LaTeX-Character-Sheet-Template/commit/b72294861d80518fe02c360c76cc44fa885b383b
Hmm... I think I did it :-)
But I didn't really test it fully... Hmm... Also, I don't know how to set prepared spells.
https://github.com/PJBrs/DND-5e-LaTeX-Character-Sheet-Template/tree/47-half-caster-spell-sheet
I can squash 'm together, if that helps!
P.S., Clearly something needs to change in dungeonsheets as well, and I didn't have all those spells for testing here.
P.P.S., So I don't know how to add the colour switches for the proficiency markers.
P.P.P.S., I just found out where the colour switches for the proficiency markers are.
P.P.P.P.S., I think I just added them, but they don't seem to render.
All looking good, thanks for picking up, I am busy the next couple of weekends, so may end up being a while before I can do this myself.
To make the spell prepared colours render, you will have to update the colours of the fill for the circle next to the spell line, they can be found as in here:
I copy pasted these in the order they appeared from the template, so there is no 100% guarantee they are in order, but they should mostly be pretty close.
Coordinates for columns 2/3 should match in the vertical, but be different in the horizontal.
I think it's quite alright now! Needs more testing with a character with over 11 cantrips, over 26 level 1 spells, and over 19 spells for levels 3, 4, and 5 each.
To make this work with dungeonsheets, you need a small patch as follows (and maybe more, I just wanted to test):
diff --git a/dungeonsheets/latex.py b/dungeonsheets/latex.py
index 2db9423..20f1918 100644
--- a/dungeonsheets/latex.py
+++ b/dungeonsheets/latex.py
@@ -282,9 +282,10 @@ def msavage_spell_info(char):
'EighthLevelSpell',
'NinthLevelSpell']
sheet_spaces = dict(zip(level_names,
- [8, 13, 13, 13, 13, 9, 9, 9, 7, 7]))
+ [11, 26, 19, 19, 19, 19, 9, 9, 7, 7]))
comp_letters = ["A", "B", "C", "D", "E", "F", "G", "H", "I", "J", "K",
- "L", "M"]
+ "L", "M", "N", "O", "P", "Q", "R", "S", "T", "U", "V",
+ "W", "X", "Y", "Z"]
spellList = char.spell_casting_info["list"]
for k, v in spellList.items():
slots_max = sheet_spaces[k]
And you need to change \renderspellsheet to \renderhalfspellsheet in dungeonsheets/forms/MSavage_template.tex.
Below picture is for my current character:
... Anyway, I'll do some more thorough testing when I get around it. Let me know if anything still is missing, if you want to turn this into a pull request, and if the commit messages need a bit more fleshing out. Or you can just grab these patches yourself, obviously.
In the meantime, suppose you had some time, it would be great if you'd test my dungeonsheets branch over here against your latest dndtemplate:
https://github.com/PJBrs/dungeon-sheets/tree/MSavage-latex-template
I'd like to see it have a little bit more testing before I open another pull request with dungeonsheets.
Looks good, my suggestions would be: Raise PR in dungeonsheets without the half caster page Raise PR in this report* When this work is merged in, submit another PR to dungeonsheets with the half caster page. That way there will be no period one is dependent on something not in the other. This looks very good though, either you can raise a PR or I can, but I’ll want to check the spells/prepared markers and it’ll be middle of next week before I get a chance.On 16 Jan 2024, at 19:12, PJBrs @.***> wrote: ... Anyway, I'll do some more thorough testing when I get around it. Let me know if anything still is missing, if you want to turn this into a pull request, and if the commit messages need a bit more fleshing out. Or you can just grab these patches yourself, obviously. In the meantime, suppose you had some time, it would be great if you'd test my dungeonsheets branch over here against your latest dndtemplate: https://github.com/PJBrs/dungeon-sheets/tree/MSavage-latex-template I'd like to see it have a little bit more testing before I open another pull request with dungeonsheets.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>
OK! In that case, it'd be great if you could test my https://github.com/PJBrs/dungeon-sheets/tree/MSavage-latex-template tree, and if you deem it successful, I'll raise that PR in dungeonsheets. I'll add the halfcastersheet PR over here after that, and then I'll figure out how to properly implement it over at dungeonsheets. Thanks!
I’ll try and have a go, but have work engagements the next 3 evenings.The reason I suggest doing things this way is that it’s usually best to keep PRs to one complete change at a time, or it can get hard to determine which code changes correspond to which feature.I have some ideas to improve the testing of this library, I didn’t like that it managed to get out of sync with dungeonsheetsSent from my iPhoneOn 16 Jan 2024, at 19:45, PJBrs @.***> wrote: OK! In that case, it'd be great if you could test my https://github.com/PJBrs/dungeon-sheets/tree/MSavage-latex-template tree, and if you deem it successful, I'll raise that PR in dungeonsheets. I'll add the halfcastersheet PR over here after that, and then I'll figure out how to properly implement it over at dungeonsheets. Thanks!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>
Thanks very much very much for merging this!!!
I hope I can use this place also two questions -
Originally posted by @PJBrs in https://github.com/matsavage/DND-5e-LaTeX-Character-Sheet-Template/issues/45#issuecomment-1880114945