search

matschaffer / knife-solo

DEPRECATED: Please consider using https://knife-zero.github.io/, ansible, or visit https://www.chef.io/ for other ideas
MIT License
786 stars 213 forks source link

remove ~ in path when cooking on a windows host to prevent the creati… #462

Open jakimowicz opened 8 years ago

jakimowicz commented 8 years ago

…on of a folder named ~ which is not usable by chef

matschaffer commented 8 years ago

Seems reasonable, but I'll need to sort out the test failures first. Looks more like something upstream than this change though.

jakimowicz commented 8 years ago

sure. Anything I can help with ?

On Wed, Nov 11, 2015 at 10:08 AM, Mat Schaffer notifications@github.com wrote:

Seems reasonable, but I'll need to sort out the test failures first. Looks more like something upstream than this change though.

— Reply to this email directly or view it on GitHub https://github.com/matschaffer/knife-solo/pull/462#issuecomment-155710073 .

http://fabien.jakimowicz.com

matschaffer commented 8 years ago

Feel like doing a bisect of chef releases to see which one broke it? ;)

On Thursday, 12 November 2015, Fabien Jakimowicz notifications@github.com wrote:

sure. Anything I can help with ?

On Wed, Nov 11, 2015 at 10:08 AM, Mat Schaffer <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Seems reasonable, but I'll need to sort out the test failures first. Looks more like something upstream than this change though.

— Reply to this email directly or view it on GitHub < https://github.com/matschaffer/knife-solo/pull/462#issuecomment-155710073> .

http://fabien.jakimowicz.com

— Reply to this email directly or view it on GitHub https://github.com/matschaffer/knife-solo/pull/462#issuecomment-155820697 .

-Mat

matschaffer.com

jakimowicz commented 8 years ago

I can give it a shot.

Can you tell me where to start from and what is expected to fail ?

On Thu, Nov 12, 2015 at 12:18 AM, Mat Schaffer notifications@github.com wrote:

Feel like doing a bisect of chef releases to see which one broke it? ;)

On Thursday, 12 November 2015, Fabien Jakimowicz <notifications@github.com

wrote:

sure. Anything I can help with ?

On Wed, Nov 11, 2015 at 10:08 AM, Mat Schaffer <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Seems reasonable, but I'll need to sort out the test failures first. Looks more like something upstream than this change though.

— Reply to this email directly or view it on GitHub <

https://github.com/matschaffer/knife-solo/pull/462#issuecomment-155710073>

.

http://fabien.jakimowicz.com

— Reply to this email directly or view it on GitHub < https://github.com/matschaffer/knife-solo/pull/462#issuecomment-155820697> .

-Mat

matschaffer.com

— Reply to this email directly or view it on GitHub https://github.com/matschaffer/knife-solo/pull/462#issuecomment-155940482 .

http://fabien.jakimowicz.com

matschaffer commented 8 years ago

The failing tests on travis will show it. The previous successes probably contain info in the logs about what chef version was used. Likely something between that version and the latest one will be where the failure happens.

The travis yaml includes info about how to run with our different gem files for different major versions.

-Mat

matschaffer.com

On Thu, Nov 12, 2015 at 8:27 AM, Fabien Jakimowicz <notifications@github.com

wrote:

I can give it a shot.

Can you tell me where to start from and what is expected to fail ?

On Thu, Nov 12, 2015 at 12:18 AM, Mat Schaffer notifications@github.com wrote:

Feel like doing a bisect of chef releases to see which one broke it? ;)

On Thursday, 12 November 2015, Fabien Jakimowicz < notifications@github.com

wrote:

sure. Anything I can help with ?

On Wed, Nov 11, 2015 at 10:08 AM, Mat Schaffer < notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Seems reasonable, but I'll need to sort out the test failures first. Looks more like something upstream than this change though.

— Reply to this email directly or view it on GitHub <

https://github.com/matschaffer/knife-solo/pull/462#issuecomment-155710073>

.

http://fabien.jakimowicz.com

— Reply to this email directly or view it on GitHub <

https://github.com/matschaffer/knife-solo/pull/462#issuecomment-155820697>

.

-Mat

matschaffer.com

— Reply to this email directly or view it on GitHub < https://github.com/matschaffer/knife-solo/pull/462#issuecomment-155940482> .

http://fabien.jakimowicz.com

— Reply to this email directly or view it on GitHub https://github.com/matschaffer/knife-solo/pull/462#issuecomment-155942331 .

matschaffer commented 8 years ago

@jakimowicz I found the failure. #463 has the details. Can you rebase this on master to get a clean build?

matschaffer commented 8 years ago

Actually just noticed that TODO is basically the exact error you hit so probably time to just take that comment out as well.

jakimowicz commented 8 years ago

I rebased the branch, but I still have some test failing related to an incorrect dns resolution.

Is it something you already encountered ?

matschaffer commented 8 years ago

That's related to your change. I suspect we need a stub on windows_node?

Otherwise it tries to call out to see if the current node is window or not.

On Sunday, 22 November 2015, Fabien Jakimowicz notifications@github.com wrote:

I rebased the branch, but I still have some test failing related to an incorrect dns resolution.

Is it something you already encountered ?

— Reply to this email directly or view it on GitHub https://github.com/matschaffer/knife-solo/pull/462#issuecomment-158743852 .

-Mat

matschaffer.com

jakimowicz commented 8 years ago

yeah, that's what I figured out.

I'll make the appropriate changes to fix it.

Thanks again.

On Sun, Nov 22, 2015 at 11:38 AM, Mat Schaffer notifications@github.com wrote:

That's related to your change. I suspect we need a stub on windows_node?

Otherwise it tries to call out to see if the current node is window or not.

On Sunday, 22 November 2015, Fabien Jakimowicz notifications@github.com wrote:

I rebased the branch, but I still have some test failing related to an incorrect dns resolution.

Is it something you already encountered ?

— Reply to this email directly or view it on GitHub < https://github.com/matschaffer/knife-solo/pull/462#issuecomment-158743852> .

-Mat

matschaffer.com

— Reply to this email directly or view it on GitHub https://github.com/matschaffer/knife-solo/pull/462#issuecomment-158744015 .

http://fabien.jakimowicz.com

matschaffer commented 8 years ago

The pleasure's all mine :)

jakimowicz commented 8 years ago

I just added the stub and a test for my change, but some builds are failing, some passes.

I also merged from master to be sure it was not caused by a recent change, but it still fails.

Since the code did not change much from master, is it normal ?

matschaffer commented 8 years ago

Looks like it could be a dependency that drifted. I'd make sure you're rebased off the latest master, though I thing the travis/pr job tests the merge so not sure if that will make a difference.

If it doesn't either you or I will have to figure out what's causing the error and lock versions appropriately.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.05%) to 89.55% when pulling fa50c730685b8d0fc542d13366cb33ddfc346467 on jakimowicz:improvement/windows_support into 5e9f6528709d63f1d9eba69d54d6bc76658df2cd on matschaffer:master.